Conversation
WoWaster
requested changes
Nov 14, 2025
Collaborator
WoWaster
left a comment
WoWaster
left a comment
There was a problem hiding this comment.
Приложите ещё исходный .c файл.
src/06oct25/main.c
Outdated
Comment on lines
6
to
8
| int number; | ||
| int data[100]; | ||
| int original_data[100]; |
Collaborator
There was a problem hiding this comment.
Переменные вот прям всегда нужно инициализировать. И стилю следовать.
Suggested change
| int number; | |
| int data[100]; | |
| int original_data[100]; | |
| int number = 0; | |
| int data[100] = { }; | |
| int originalData[100] = { }; |
src/06oct25/main.c
Outdated
|
|
||
| while (scanf("%d", &number) == 1) { | ||
| data[index] = number; | ||
| original_data[index] = number; // сохраняем копию исходного массива |
Collaborator
There was a problem hiding this comment.
Комментарии лучше писать над сущностью.
src/06oct25/merge_sort.h
Outdated
| #pragma once | ||
|
|
||
| /* Сортировка слиянием */ | ||
| void merge_sort(int data[], int size); No newline at end of file |
Collaborator
There was a problem hiding this comment.
Инструкции по сборке нет :(
Collaborator
There was a problem hiding this comment.
Я вот так сходу не уверен, что Вы собрали этот код с оптимизациями.
src/06oct25/main.c
Outdated
| printf("\n"); | ||
|
|
||
| // подсчитываем различия | ||
| int moved_count = 0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| int moved_count = 0; | |
| int movedCount = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Сортировка слиянием на языке ассемблера и основной файл на C